gh-148228: Enable error overlays in the REPL#148229
Conversation
johnslavik
changed the title
| t = THEME() | ||
| error_prefix = f"{t.error}{error_prefix}{t.reset}" | ||
| self.console.beep() | ||
| self.msg = error_prefix + msg |
There was a problem hiding this comment.
Maybe I am misreading this flow but if I am not wrong, the error() now embeds the escape sequences into self.msg. The message renderer at _render_message_lines slices by string length, not visible width. Then, len(message_line) counts the ANSI bytes (\x1b[1;31m ... \x1b[0m), so on narrow terminals (or long error messages) the slice boundary can land mid-escape, producing a truncated \x1b[ on one line and stray m on the next leaving the whole line un-colored or visually corrupted.
There was a problem hiding this comment.
I wired it to use the same wrapping method as layout_content_lines. Should be fine now!
(Taking this to extremes, we don't handle splitting prompt string if terminal is too narrow. Technically anyone can set their own prompt string, so maybe we should?)
Documentation build overview
19 files changed ·
|
1d02b0f to
8cb9bc0
Compare
2 participants
Small proof of concept for gh-148228. We can build on this further on.