gh-153864: Fix curses window.insch() for non-ASCII characters on a wide build#153865
Merged
serhiy-storchaka merged 2 commits intoJul 19, 2026
Merged
Conversation
…n a wide build On a wide build, winsch() does not locale-decode a byte above 127, unlike waddch(), so insch() inserted '¤' (U+00A4) instead of '€' for byte 0xA4 under ISO-8859-15. Decode the byte with btowc() and insert it as a wide character, like addch(). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 19, 2026 07:45
|
GH-154117 is a backport of this pull request to the 3.15 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 19, 2026
…on a wide build (GH-153865) (GH-154117) On a wide build, winsch() does not locale-decode a byte above 127, unlike waddch(), so insch() inserted '¤' (U+00A4) instead of '€' for byte 0xA4 under ISO-8859-15. Decode the byte with btowc() and insert it as a wide character, like addch(). (cherry picked from commit 223cbff) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
|
GH-154152 is a backport of this pull request to the 3.14 branch. |
|
GH-154154 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 19, 2026
…on a wide build (GH-153865) (GH-154154) On a wide build, winsch() does not locale-decode a byte above 127, unlike waddch(), so insch()/mvinsch() stored the wrong character for a non-ASCII byte of an 8-bit locale ('€' 0xA4 under ISO-8859-15 became U+00A4 '¤'). Decode the byte with btowc() and insert it as a wide character, as addch() effectively does. (cherry picked from commit 223cbff) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 19, 2026
…on a wide build (GH-153865) (GH-154152) On a wide build, winsch() does not locale-decode a byte above 127, unlike waddch(), so insch()/mvinsch() stored the wrong character for a non-ASCII byte of an 8-bit locale ('€' 0xA4 under ISO-8859-15 became U+00A4 '¤'). Decode the byte with btowc() and insert it as a wide character, as addch() effectively does. (cherry picked from commit 223cbff) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a wide (
ncursesw) build,window.insch()andwindow.mvinsch()insert a non-ASCIIint/bytesbyte as its Latin-1 code point instead of decoding it through the window's encoding, unlikeaddch()— e.g.insch(0xA4)under ISO-8859-15 inserts¤(U+00A4) whileaddch(0xA4)inserts€.The cause is in ncurses:
winsch()has a fast path for a printable 8-bit byte that stores it directly as a code point, bypassing the locale decodewaddch()performs. The fix decodes the byte withbtowc()(the inverse ofinch()'swctob()) and inserts it withwins_wch(); a byte with no single-byte form in the locale falls back towinsch().The underlying ncurses behavior was reported upstream.