gh-153854: Raise ValueError from imaplib.Time2Internaldate on empty string#153874
Open
fedonman wants to merge 2 commits into
Open
gh-153854: Raise ValueError from imaplib.Time2Internaldate on empty string#153874fedonman wants to merge 2 commits into
fedonman wants to merge 2 commits into
Conversation
…mpty string Time2Internaldate() is documented to raise ValueError for input that is not of a known type, and its final branch does so. However, the string branch subscripted the value with date_time[0]/date_time[-1] before that check, so an empty string escaped as a bare IndexError. Use str.startswith() and str.endswith() instead, which handle the empty string gracefully while preserving behaviour for every other input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imaplib.Time2Internaldateis documented to raiseValueErrorfor inputthat is not of a known type, and its final branch does so. However, the
string branch subscripted the value before that check:
so an empty string escaped as a bare
IndexError:This replaces the subscript comparison with
str.startswith('"')andstr.endswith('"'), which handle the empty string gracefully whilepreserving behaviour for every other input (a properly double-quoted
string is still passed through unchanged; anything else raises
ValueError).Regression tests are added for the empty/malformed string cases and for
the quoted-string passthrough.
🤖 Generated with Claude Code