Improved test coverage for codeop.py. - #154100
Merged
Merged
Conversation
* Ported existing tests to cover both the CommandCompiler and Compile classes * Added tests that cover the case when PyCF_ONLY_AST is set * Added tests that cover the case when the compile method returns a code object with flags
* Moved test set up to module scope * Use subTests decorator to inject compiler parameter into tests * Introduced new compiler parameter to assert* family of methods * Used functools to maintain the same API for the assert* methods where applicable
…python into improve-codeop-test-coverage
Contributor
Author
|
Thanks a lot for the feedback! I've implemented the changes you proposed and pushed them to my branch, so feel free to take a look when you can. |
encukou
approved these changes
Jul 30, 2026
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
Thank you!
For the future: you don't need to push "Update branch", unless there are merge conflicts.
encukou
added
needs backport to 3.14
|
Thanks @vjabuilds for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Thanks @vjabuilds for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @vjabuilds and @encukou, I could not cleanly backport this to |
|
GH-154938 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the test coverage for codeop.py.