[deprecation] Deprecate CoalesceToTernaryRector as risky - #8324
Merged
Conversation
The "??" and "?:" operators are not interchangeable. "?:" also falls back on falsy values like empty string, "0" and empty array, so the change can silently alter behavior. A regression has to be fixed manually, so the rule is deprecated instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoalesceToTernaryRectorturns??into?:when the left side is non-nullable. But those operators are not interchangeable:??only falls back onnull, while?:falls back on every falsy value.function run(string $a) { - return $a ?? 'foo'; + return $a ?: 'foo'; } run(''); // before: "", after: "foo" run('0'); // before: "0", after: "foo"The same applies to
0,0.0,[]andfalse. The rule is type-safe on paper, but the value change is silent and only shows up at runtime, so a regression has to be found and fixed manually.Deprecated the same way as
SwitchNegatedTernaryRector: implementsDeprecatedInterface,refactor()throws, tests removed. The rule is not part of any set, so no set list changes.