Skip to content

address context shutdown racy condition. - #3219

Merged
skyegalaxy merged 1 commit into
lyricalfrom
fujitatomoya/lyrical/racy-context-shutdown
Aug 12, 2026
Merged

address context shutdown racy condition.#3219
skyegalaxy merged 1 commit into
lyricalfrom
fujitatomoya/lyrical/racy-context-shutdown

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Description

retarget #3217 to lyrical

Fixes # (issue)

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
@fujitatomoya fujitatomoya self-assigned this Aug 11, 2026

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ABI compatibility change, so that we can put this to lyrical and downstream branches.

@mergify

mergify Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

Pulls: #3219
Gist: https://gist.githubusercontent.com/fujitatomoya/977ef70875dc4467b6f510f9db8e39a5/raw/2cb0f02adf8bf5ad334675d3d51445cf204e17ed/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20058

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@skyegalaxy skyegalaxy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author
  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@skyegalaxy
skyegalaxy merged commit b723878 into lyrical Aug 12, 2026
3 checks passed
@skyegalaxy

Copy link
Copy Markdown
Member

https://github.com/Mergifyio backport humble jazzy kilted

@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

backport humble jazzy kilted

✅ Backports have been created

Details

Cherry-pick of b723878 has failed:

On branch mergify/bp/humble/pr-3219
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b723878.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclcpp/src/rclcpp/signal_handler.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   rclcpp/src/rclcpp/context.cpp
	deleted by us:   rclcpp/test/rclcpp/test_context.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of b723878 has failed:

On branch mergify/bp/jazzy/pr-3219
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit b723878.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclcpp/src/rclcpp/signal_handler.cpp
	modified:   rclcpp/test/rclcpp/test_context.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/src/rclcpp/context.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of b723878 has failed:

On branch mergify/bp/kilted/pr-3219
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit b723878.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclcpp/src/rclcpp/signal_handler.cpp
	modified:   rclcpp/test/rclcpp/test_context.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/src/rclcpp/context.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants