#5568 Fix kit allocation/deallocation history display direction (fixes #5568)#5628
Open
rodrigovirgilio wants to merge 3 commits into
Open
#5568 Fix kit allocation/deallocation history display direction (fixes #5568)#5628rodrigovirgilio wants to merge 3 commits into
rodrigovirgilio wants to merge 3 commits into
Conversation
dorner
requested changes
Jul 10, 2026
| # kit's own line item (always last) moves opposite the component items, so the | ||
| # row's From/To direction must be derived from the kit line item, not the first one. | ||
| is_kit_event = event.is_a?(KitAllocateEvent) || event.is_a?(KitDeallocateEvent) | ||
| direction_item = is_kit_event ? event.data.items.last : event.data.items.first |
Collaborator
There was a problem hiding this comment.
This seems flaky. We shouldn't be depending on ordering here. Should we not just multiply the values by -1?
rodrigovirgilio
force-pushed
the
fix/kit-allocation-history-display
branch
from
750e14a to
6fe19ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5568
Description
KitAllocateEvent/KitDeallocateEvent mix directions within a single event (components move one way, the kit item moves the other), and the kit's own line item is always last in the array. The history view derived From/To and quantity sign from the first item, which picked the component's direction instead of the kit's — showing kit counts negative and under the wrong location column. Now derives direction from the kit's line item for these two event types; underlying inventory math is untouched.
Type of change
How Has This Been Tested?
Screenshots