shard aware: Move ShardInfo class into a Cython - #48
Merged
Conversation
ultrabug
approved these changes
Jun 29, 2020
ultrabug
left a comment
ultrabug
left a comment
There was a problem hiding this comment.
LGTM, should be a good optimization
fruch
force-pushed
the
cython_shared_aware
branch
7 times, most recently
from
June 30, 2020 13:39
ebc386f to
694d302
Compare
fruch
force-pushed
the
cython_shared_aware
branch
from
June 30, 2020 17:05
694d302 to
aa6db57
Compare
since the computation was quite naive to begin with and in pure python we could do much better with a calculation purely in C.
fruch
force-pushed
the
cython_shared_aware
branch
from
June 30, 2020 17:19
aa6db57 to
59c9b54
Compare
Author
No one is :) |
seem like it even fix the windows issue
fruch
force-pushed
the
cython_shared_aware
branch
from
June 30, 2020 18:56
52061bb to
5fc4b74
Compare
tzach
pushed a commit
to tzach/python-driver
that referenced
this pull request
Aug 31, 2022
Update docs for 3.22 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the computation was quite naive to begin with and in pure python
we could do much better with a calculation purely in C.