fix: replace version-environment-key on ECS deploys instead of appending - #7
Closed
roybrouwer wants to merge 1 commit into
Closed
fix: replace version-environment-key on ECS deploys instead of appending#7roybrouwer wants to merge 1 commit into
roybrouwer wants to merge 1 commit into
Conversation
Ploy copied the running task definition and appended the version env var on every deploy, so DD_VERSION (and any other version-environment-key) accumulated duplicate entries. Upsert in place and drop leftovers. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Closing per request — not pursuing this approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version-environment-keycopied the running task definition and appended the env var on every deploy, so keys likeDD_VERSIONaccumulated duplicate entries.Test plan
go test ./engine/v*release sosource-deployments(ploy@latest) picks this up before relying onversion-environment-key: DD_VERSIONfor BFF.Made with Cursor