Skip to content

Avoid experiment reloads when loading the dashboard #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrehjr merged 2 commits into from
Aug 9, 2026
Merged

Avoid experiment reloads when loading the dashboard #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c58d20b
Default an experiment's goals to an empty array
andrehjr Aug 9, 2026
fe08eae
Give alternatives a back-reference to their experiment
andrehjr Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/split/alternative.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class Alternative
attr_accessor :experiment_name
attr_accessor :weight
attr_accessor :recorded_info
attr_writer :experiment

def initialize(name, experiment_name)
@experiment_name = experiment_name
Expand Down Expand Up @@ -100,7 +101,7 @@ def conversion_rate(goal = nil)
end

def experiment
Split::ExperimentCatalog.find(experiment_name)
@experiment ||= Split::ExperimentCatalog.find(experiment_name)
end

def z_score(goal = nil)
Expand Down
3 changes: 2 additions & 1 deletion lib/split/experiment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def set_alternatives_and_options(options)
)

self.alternatives = options_with_defaults[:alternatives]
self.goals = options_with_defaults[:goals]
self.goals = options_with_defaults[:goals] || []
self.resettable = options_with_defaults[:resettable]
self.algorithm = options_with_defaults[:algorithm]
self.metadata = options_with_defaults[:metadata]
Expand Down Expand Up @@ -145,6 +145,7 @@ def alternatives=(alts)
Split::Alternative.new(alternative, @name)
end
end
@alternatives.each { |alternative| alternative.experiment = self }
end

def winner
Expand Down
Loading