Dashboard modernization - #760
Merged
Merged
Conversation
- Remove jQuery; dashboard behaviours are vanilla JS. Make all css/js simpler. - Add dark mode. - Make eslint work again. - Simplify Dashboard logic - Remove some duplicated Redis calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big one, I've been working on.
I've used Claude to help refactor the Dashboard Front-End and remove some of the old javascript and jquery stuff. Adding Dark mode too!
The old UI and having an ancient version of jQuery was bugging me for sometime. One thing I'd also like to do in the future, it to remove the requirement Sinatra, or using Rails engines directly.
This PR adds a few niceties, such as displaying the current overrides. This bit me off a few times in the past.
It also made a refactor on the controller side to reduce the number of redis calls made. Improving the overall loading performance.