Add optimized DataBufferInputStream overrides - #34799
Closed
kilink wants to merge 1 commit into
Closed
Conversation
Add optimized DataBufferInputStream overrides for readNBytes, skip, and transferTo; all of them allocate byte buffers which we can either avoid (in the case of skip) or size more precisely since the number of remaining bytes is known. Signed-off-by: Patrick Strawderman <pstrawderman@netflix.com>
kilink
force-pushed
the
data-buffer-inputstream-overrides
branch
from
April 22, 2025 23:05
1c80d32 to
9b1b474
Compare
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: enhancement
bclozel
added
the
in: core
Member
|
Thanks @kilink and sorry for the delay. I merged this back into 6.2.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optimized DataBufferInputStream overrides for readNBytes, skip, and transferTo; all of them allocate byte buffers which we can either avoid (in the case of skip) or size more precisely since the number of remaining bytes is known.
Note that
transferTocould potentially be optimized further; for instance if the passed in OutputStream is a DataBufferOutputStream, it could potentially do some special handling.