Declare messageSelector parameters in JmsOperations as @Nullable

[mjd507]

No description provided.

[mjd507]

@artembilan I saw in spring-integration-jms, we have below code (in class JmsDestinationPollingSource)

	private jakarta.jms.Message doReceiveJmsMessage() {
		jakarta.jms.Message jmsMessage;
		if (this.destination != null) {
			jmsMessage = this.jmsTemplate.receiveSelected(this.destination, this.messageSelector);
		}
		else if (this.destinationName != null) {
			jmsMessage = this.jmsTemplate.receiveSelected(this.destinationName, this.messageSelector);
		}
		else {
			jmsMessage = this.jmsTemplate.receiveSelected(this.messageSelector);
		}
		return jmsMessage;
	}

first two receiveSelected method are Ok, the parameter messageSelector are marked as Nullable (marked in child class, super class not marked, but this looks fine, we are calling from child only).
however, the third method receiveSelected(this.messageSelector); parameter is not marked as Nullable,

I don't see any reason it can be non-null. so I made these small changes.

[artembilan]

Thank you @mjd507 !
I cannot merge this PR, so we would need to wait for the feedback from Spring Framework team.

[sbrannen]

Hi @mjd507,

Congratulations on submitting your first PR for the Spring Framework! 👍

I noticed you actually missed a few additional places where messageSelector should be @Nullable; however, I already merged your work locally on 6.2.x and started addressing the additional methods.

So, there's no need to modify this PR.

Cheers,

Sam

[mjd507]

thank you @sbrannen, close this.

May I know when it can be merged into 'main' branch ?

[sbrannen]

This has been merged into 6.2.x and main in b6675ed and revised in 133f330.

Thanks