feat(ansible): delegate extension version handling to site-extensions-update - #2324
Draft
brainrake wants to merge 4 commits into
Draft
feat(ansible): delegate extension version handling to site-extensions-update#2324brainrake wants to merge 4 commits into
brainrake wants to merge 4 commits into
Conversation
…-update postgres_prestart.sh's handle_extension_versions() now calls site-extensions-update directly instead of looping switch_<ext>_version per extension -- that resolve/download/install pipeline now lives in the nix packages added by #2317. Manifest-missing guard preserved; failure is non-fatal (matches existing behavior, and ExecStartPre already ignores exit status via the -+ prefix). Also fixes drift in postgresql.service: it had fallen out of sync with salt's live copy of the unit (ExecStartPre missing the "-" ignore-failure prefix, ReadOnlyPaths missing /usr/local). Both now match what's actually deployed on the fleet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - WIP. Depends on #2317 and #2283.
Part of PSQL-1530.
postgres_prestart.sh'shandle_extension_versions()now delegates tosite-extensions-updateinstead of loopingswitch_<ext>_versionper extension.Also fixes drift in
postgresql.service: it had fallen out of sync with salt's live copy of the unit (ExecStartPremissing the-ignore-failure prefix,ReadOnlyPathsmissing/usr/local). Both now match what's actually deployed on the fleet.Also blocked on: Postgres's
dynamic_library_path/extension_control_pathneeds thesite-extensionsprofile path added (drafted in the PSQL-1530 issue's migration plan, not yet implemented).