Skip to content

Support additional flags in FirestoreEmulatorContainer #10067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 1 commit into from
Mar 5, 2025
Merged

Support additional flags in FirestoreEmulatorContainer #10067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion modules/gcloud/src/main/java/org/testcontainers/containers/FirestoreEmulatorContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public class FirestoreEmulatorContainer extends GenericContainer<FirestoreEmulat

private static final int PORT = 8080;

private String flags;

public FirestoreEmulatorContainer(String image) {
this(DockerImageName.parse(image));
}
Expand All @@ -34,7 +36,20 @@ public FirestoreEmulatorContainer(final DockerImageName dockerImageName) {

withExposedPorts(PORT);
setWaitStrategy(Wait.forLogMessage(".*running.*$", 1));
withCommand("/bin/sh", "-c", CMD);
}

@Override
protected void configure() {
String command = CMD;
if (this.flags != null && !this.flags.isEmpty()) {
command += " " + this.flags;
}
withCommand("/bin/sh", "-c", command);
}

public FirestoreEmulatorContainer withFlags(String flags) {
this.flags = flags;
return this;
}

/**
Expand Down
15 changes: 15 additions & 0 deletions ...es/gcloud/src/test/java/org/testcontainers/containers/FirestoreEmulatorContainerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@ public void testSimple() throws ExecutionException, InterruptedException {

assertThat(querySnapshot.getDocuments().get(0).getData()).containsEntry("first", "Ada");
}

// }

@Test
public void testWithFlags() {
try (
FirestoreEmulatorContainer emulator = new FirestoreEmulatorContainer(
"gcr.io/google.com/cloudsdktool/google-cloud-cli:465.0.0-emulators"
)
.withFlags("--database-mode datastore-mode")
) {
emulator.start();

assertThat(emulator.getContainerInfo().getConfig().getCmd())
.anyMatch(e -> e.contains("--database-mode datastore-mode"));
}
}
}