Skip to content

Avoid duplicate values for listeners and listener_security_protocol_map in KafkaContainer #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 1 commit into from
Jul 5, 2024
+21 −8
Merged

Avoid duplicate values for listeners and listener_security_protocol_map in KafkaContainer #8850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,14 +323,8 @@ void withClusterId(String clusterId) {
void withRaft() {
this.envVars.computeIfAbsent("CLUSTER_ID", key -> clusterId);
this.envVars.computeIfAbsent("KAFKA_NODE_ID", key -> getEnvVars().get("KAFKA_BROKER_ID"));
addEnvVar(
"KAFKA_LISTENER_SECURITY_PROTOCOL_MAP",
String.format("%s,CONTROLLER:PLAINTEXT", getEnvVars().get("KAFKA_LISTENER_SECURITY_PROTOCOL_MAP"))
);
addEnvVar(
"KAFKA_LISTENERS",
String.format("%s,CONTROLLER://0.0.0.0:9094", getEnvVars().get("KAFKA_LISTENERS"))
);
addEnvVar("KAFKA_LISTENER_SECURITY_PROTOCOL_MAP", kafkaListenerSecurityProtocolMap());
addEnvVar("KAFKA_LISTENERS", kafkaListeners());
addEnvVar("KAFKA_PROCESS_ROLES", "broker,controller");

String firstNetworkAlias = getNetworkAliases().stream().findFirst().orElse(null);
Expand All @@ -345,5 +339,24 @@ void withRaft() {

setWaitStrategy(Wait.forLogMessage(".*Transitioning from RECOVERY to RUNNING.*", 1));
}

private String kafkaListenerSecurityProtocolMap() {
String kafkaListenerSecurityProtocolMapEnvVar = getEnvVars().get("KAFKA_LISTENER_SECURITY_PROTOCOL_MAP");
String kafkaListenerSecurityProtocolMap = String.format(
"%s,CONTROLLER:PLAINTEXT",
kafkaListenerSecurityProtocolMapEnvVar
);
Set<String> listenerSecurityProtocolMap = new HashSet<>(
Arrays.asList(kafkaListenerSecurityProtocolMap.split(","))
);
return String.join(",", listenerSecurityProtocolMap);
}

private String kafkaListeners() {
String kafkaListenersEnvVar = getEnvVars().get("KAFKA_LISTENERS");
String kafkaListeners = String.format("%s,CONTROLLER://0.0.0.0:9094", kafkaListenersEnvVar);
Set<String> listeners = new HashSet<>(Arrays.asList(kafkaListeners.split(",")));
return String.join(",", listeners);
}
}
}