Skip to content

remove octal literals#28

Closed
goya wants to merge 1 commit into
thejoshwolfe:masterfrom
goya:master
Closed

remove octal literals#28
goya wants to merge 1 commit into
thejoshwolfe:masterfrom
goya:master

Conversation

@goya

@goya goya commented Oct 27, 2016

Copy link
Copy Markdown

allows strict mode support.

@thejoshwolfe

Copy link
Copy Markdown
Owner

Great idea. I hate octal literals, but unix permissions still seems like a legitimate usecase to me.

I've replaced the octal literals with calls to parseInt() with an explicit radix of 8. Aside from the tiny increase in startup time, my idea is functionally identical to yours, and it still keeps the octal syntax for readability.

Thanks for the PR anyway.

@goya

goya commented Oct 27, 2016

Copy link
Copy Markdown
Author

no worries. let and const wait for no person. cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants