uniq: optimize memory usage for ignore-case comparison - #10050
Merged
Conversation
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #10050 will improve performance by 7.04%Comparing Summary
Benchmarks breakdown
Footnotes
|
CrazyRoka
force-pushed
the
uniq-optimize-case-sensitive
branch
from
January 4, 2026 19:39
12f3e7f to
28deca2
Compare
|
GNU testsuite comparison: |
CrazyRoka
marked this pull request as ready for review
January 4, 2026 21:40
Contributor
|
Nice refactoring, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when running
uniq -i, the implementation eagerly allocated a new vector and copied the lowercased line into it for every single line read. Profiling indicated thatbuild_metaaccounted for a significant portion of execution time (approx 27%) due to this allocation.This change removes the
lowercasebuffer fromLineMetaentirely. Instead, it implements a lazy, iterator-based comparison inkeys_differ. This eliminates the per-line allocation overhead and enables short-circuiting during comparison.