pr: ignore empty line after newline char - #10332
Conversation
CodSpeed Performance ReportMerging this PR will degrade performance by 15.33%Comparing Summary
Performance Changes
Footnotes
|
Fix a bug in `pr` where a form feed character (`\f`) immediately following a newline character (`\n`) was incorrectly rendered as an extra blank line in the output when running with the `-f` option. After this commit, the empty line is correctly ignored.
c320271 to
0e36e4b
Compare
|
GNU testsuite comparison: |
|
This overall made the GNU test failures go down by 10 but also introduced 6 regressions, Its due to issues in the line_num count. I'm trying to figure out locally what the missing conditions are. EDIT: My bad was not comparing the right upstream main, there were 6 test fixes and no regressions |
|
I've been messing around for a while to see what are the causes of the regressions before the most recent set of PR changes: These ones began failing after: "597361324 (pr: ignore empty line after form feed char #10331)" but I m unable to replicate what the fix would be for these since there are multiple issues that appear to cancel out that make these tests pass. So in that other PR, even though the logic was correct it still caused these regressions |
Depends on #10303.
Fix a bug in
prwhere a form feed character (\f) immediatelyfollowing a newline character (
\n) was incorrectly rendered as anextra blank line in the output when running with the
-foption. Afterthis commit, the empty line is correctly ignored.