Skip to content

wc: respect POSIXLY_CORRECT for word counting - #10344

Merged
cakebaker merged 2 commits into
uutils:mainfrom
dhr412:posix-corr-wc
Jan 20, 2026
Merged

wc: respect POSIXLY_CORRECT for word counting#10344
cakebaker merged 2 commits into
uutils:mainfrom
dhr412:posix-corr-wc

Conversation

@dhr412

@dhr412 dhr412 commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Closes #10321
Should I add a test as well?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ptx/ptx-overrun is no longer failing!

@sylvestre

Copy link
Copy Markdown
Contributor

Yes for tests. It is rare that we accept a pr without it

@codspeed-hq

codspeed-hq Bot commented Jan 19, 2026

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will degrade performance by 4.44%

Comparing dhr412:posix-corr-wc (db7d458) with main (6381266)

Summary

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 280 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_key_field[500000] 31.4 MB 32.8 MB -4.44%
Memory du_wide_tree[(5000, 500)] 1.3 MB 1.2 MB +7.39%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ptx/ptx-overrun is no longer failing!

@cakebaker
cakebaker merged commit a74f72f into uutils:main Jan 20, 2026
155 of 157 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wc: incorrect POSIXLY_CORRECT whitespace rules

3 participants