Skip to content

hashsum: Drop non-GNU --bits flag - #9773

Merged
cakebaker merged 1 commit into
uutils:mainfrom
RenjiSann:hashsum-drop-bits
Dec 23, 2025
Merged

hashsum: Drop non-GNU --bits flag#9773
cakebaker merged 1 commit into
uutils:mainfrom
RenjiSann:hashsum-drop-bits

Conversation

@RenjiSann

@RenjiSann RenjiSann commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Split from #9770, needs to be merged after it

cc @oech3

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@cakebaker

Copy link
Copy Markdown
Contributor

Is this PR still needed, with #9776 planning to remove hashsum?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

Is this PR still needed, with #9776 planning to remove hashsum?

#9776 depends on this, I wanted to split them since both are pretty big changes by themselves, but I can merge them if you prefer

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@codspeed-hq

codspeed-hq Bot commented Dec 22, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #9773 will not alter performance

Comparing RenjiSann:hashsum-drop-bits (deaf44a) with main (8d3774b)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@cakebaker
cakebaker merged commit c811fb9 into uutils:main Dec 23, 2025
125 of 127 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@RenjiSann
RenjiSann deleted the hashsum-drop-bits branch December 23, 2025 10:24
@oech3

oech3 commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

I'm not sure. But I think recient commit increased binary size 0.2 MB+.

@RenjiSann

Copy link
Copy Markdown
Collaborator Author

I'm not sure. But I think recient commit increased binary size 0.2 MB+.

Are you taking about the size of the hashsum or coreutils binary, or both ?
I don't know what in this PR or #9770 might have changed that though 🤔

@oech3

oech3 commented Dec 23, 2025 via email

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants