split: Added error when attempting to create file that already exists as directory - #9945
Merged
sylvestre merged 8 commits intoJan 2, 2026
Merged
Conversation
max-amb
marked this pull request as draft
December 31, 2025 14:11
max-amb
marked this pull request as ready for review
December 31, 2025 14:25
Contributor
Author
|
I am confused why the windows test doesn't work, the code in unix.rs and windows.rs seems the same to me. Can anyone help? |
Contributor
|
|
Contributor
Author
|
csplit does this differently, with let file = File::open(file_name)
.map_err_context(|| format!("cannot open {} for reading", file_name.quote()))?;
Ok(csplit(&options, &patterns, BufReader::new(file))?)in |
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 1, 2026
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 2, 2026
| _ => Error::other( | ||
| translate!("split-error-unable-to-open-file", "file" => filename), | ||
| ) | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
Rust linting in the pre-commit hook doesn't like it not being there, i.e. cargo fmt requires it to be there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9937
Not sure if error message could be better named