Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.util.Set;

import io.weaviate.client.v1.graphql.query.util.Serializer;
import java.util.stream.Collectors;
import lombok.AccessLevel;
import lombok.Builder;
import lombok.EqualsAndHashCode;
Expand All @@ -25,6 +26,7 @@ public class HybridArgument implements Argument {
String fusionType;
String[] properties;
String[] targetVectors;
Searches searches;


@Override
Expand All @@ -47,7 +49,26 @@ public String build() {
if (ArrayUtils.isNotEmpty(targetVectors)) {
arg.add(String.format("targetVectors:%s", Serializer.arrayWithQuotes(targetVectors)));
}
if (searches != null && (searches.nearVector != null || searches.nearText != null)) {
Set<String> searchesArgs = new LinkedHashSet<>();
if (searches.nearVector != null) {
searchesArgs.add(searches.nearVector.build());
}
if (searches.nearText != null) {
searchesArgs.add(searches.nearText.build());
}
arg.add(String.format("searches:{%s}", String.join(" ", searchesArgs)));
}

return String.format("hybrid:{%s}", String.join(" ", arg));
}

@Getter
@Builder
@ToString
@FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
public static class Searches {
NearVectorArgument nearVector;
NearTextArgument nearText;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,38 @@ public void shouldCreateArgumentWithProperties() {
assertThat(str).isEqualTo("hybrid:{query:\"I'm a simple string\" " +
"properties:[\"prop1\",\"prop2\"]}");
}

@Test
public void shouldCreateArgumentWithNearVectorSearches() {
NearVectorArgument nearVector = NearVectorArgument.builder()
.vector(new Float[]{ .1f, .2f, .3f })
.certainty(0.9f)
.build();

HybridArgument hybrid = HybridArgument.builder()
.query("I'm a simple string")
.searches(HybridArgument.Searches.builder().nearVector(nearVector).build())
.build();

String str = hybrid.build();

assertThat(str).isEqualTo("hybrid:{query:\"I'm a simple string\" searches:{nearVector:{vector:[0.1,0.2,0.3] certainty:0.9}}}");
}

@Test
public void shouldCreateArgumentWithNearTextSearches() {
NearTextArgument nearText = NearTextArgument.builder()
.concepts(new String[]{"concept"})
.certainty(0.9f)
.build();

HybridArgument hybrid = HybridArgument.builder()
.query("I'm a simple string")
.searches(HybridArgument.Searches.builder().nearText(nearText).build())
.build();

String str = hybrid.build();

assertThat(str).isEqualTo("hybrid:{query:\"I'm a simple string\" searches:{nearText:{concepts:[\"concept\"] certainty:0.9}}}");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,7 @@ public void testGraphQLGetWithGroupBy() {
Config config = new Config("http", address);
WeaviateClient client = new WeaviateClient(config);
WeaviateTestGenerics.DocumentPassageSchema testData = new WeaviateTestGenerics.DocumentPassageSchema();
;

List<GroupHitOfDocument> ofDocumentA = Collections.singletonList(
new GroupHitOfDocument(new AdditionalOfDocument(testData.DOCUMENT_IDS[0]))
);
Expand Down Expand Up @@ -1630,6 +1630,68 @@ public void testGraphQLGetWithGroupBy() {
checkGroupElements(expectedHits2, groups.get(1).getHits());
}

@Test
public void testGraphQLGetWithGroupByWithHybrid() {
// given
Config config = new Config("http", address);
WeaviateClient client = new WeaviateClient(config);
WeaviateTestGenerics.DocumentPassageSchema testData = new WeaviateTestGenerics.DocumentPassageSchema();
// hits
Field[] hits = new Field[]{
Field.builder().name("content").build(),
Field.builder().name("_additional{id distance}").build(),
};
// group
Field group = Field.builder()
.name("group")
.fields(new Field[]{
Field.builder().name("id").build(),
Field.builder().name("groupedBy")
.fields(new Field[]{
Field.builder().name("value").build(),
Field.builder().name("path").build(),
}).build(),
Field.builder().name("count").build(),
Field.builder().name("maxDistance").build(),
Field.builder().name("minDistance").build(),
Field.builder().name("hits").fields(hits).build(),
}).build();
// _additional
Field _additional = Field.builder().name("_additional").fields(new Field[]{group}).build();
// filter arguments
GroupByArgument groupBy = client.graphQL().arguments().groupByArgBuilder()
.path(new String[]{"content"}).groups(3).objectsPerGroup(10).build();
NearTextArgument nearText = NearTextArgument.builder().concepts(new String[]{"Passage content 2"}).build();
HybridArgument hybrid = HybridArgument.builder()
.searches(HybridArgument.Searches.builder().nearText(nearText).build())
.query("Passage content 2")
.alpha(0.9f)
.build();
// when
testData.createAndInsertData(client);
Result<GraphQLResponse> groupByResult = client.graphQL().get()
.withClassName(testData.PASSAGE)
.withHybrid(hybrid)
.withGroupBy(groupBy)
.withFields(_additional).run();
testData.cleanupWeaviate(client);
// then
assertThat(groupByResult).isNotNull();
assertThat(groupByResult.getError()).isNull();
assertThat(groupByResult.getResult()).isNotNull();
List<Map<String, Object>> result = extractResult(groupByResult, testData.PASSAGE);
assertThat(result).isNotNull().hasSize(3);
List<Group> groups = getGroups(result);
assertThat(groups).isNotNull().hasSize(3);
for (int i = 0; i < 3; i++) {
if (i == 0) {
assertThat(groups.get(i).groupedBy.value).isEqualTo("Passage content 2");
}
assertThat(groups.get(i).minDistance).isEqualTo(groups.get(i).getHits().get(0).get_additional().getDistance());
assertThat(groups.get(i).maxDistance).isEqualTo(groups.get(i).getHits().get(groups.get(i).getHits().size() - 1).get_additional().getDistance());
}
}

private void checkGroupElements(List<GroupHit> expected, List<GroupHit> actual) {
assertThat(expected).hasSameSizeAs(actual);
for (int i = 0; i < actual.size(); i++) {
Expand Down