Skip to content

Add missing dependency libglib2.0-dev to docs - #213

Merged
willprice merged 1 commit into
willprice:masterfrom
atoav:patch-1
Feb 9, 2021
Merged

Add missing dependency libglib2.0-dev to docs#213
willprice merged 1 commit into
willprice:masterfrom
atoav:patch-1

Conversation

@atoav

@atoav atoav commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

Description

As mentioned in issue #198 the libglib2.0-dev is not pre-installed in current Raspbian versions. Had the same occur to me with a fresh Raspbian Buster on a RPi 3+ today. To reduce friction for first time users, I suggest adding it to the docs as there is no harm for users that already have it installed on their systems.

  • Status: READY

Steps to Test or Reproduce

  1. Install current Raspbian default variant
  2. Install old documented dependencies
  3. pip3 install omxplayer-wrapper
  4. Get an error
  5. apt install libglib2.0-dev
  6. again: pip3 install omxplayer-wrapper
  7. Installation works

As mentioned in issue willprice#198 the `libglib2.0-dev` is not pre-installed in current Raspbian versions. Had the same occur to me with a fresh Raspbian Buster on a RPi 3+ today. To reduce friction for first time users, I suggest adding it to the docs.
@codecov

codecov Bot commented Feb 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #213 (8441787) into master (a9875e3) will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   73.82%   73.40%   -0.43%     
==========================================
  Files           6        6              
  Lines         470      470              
  Branches       26       26              
==========================================
- Hits          347      345       -2     
- Misses        113      115       +2     
  Partials       10       10              
Impacted Files Coverage Δ
omxplayer/player.py 81.05% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9875e3...8441787. Read the comment docs.

@willprice

Copy link
Copy Markdown
Owner

Great, thanks atoav!

@willprice
willprice merged commit 096acad into willprice:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants