NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 1 | login bug - #238
Open
ZabihollahNamazi wants to merge 2 commits into
Open
NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 1 | login bug#238ZabihollahNamazi wants to merge 2 commits into
ZabihollahNamazi wants to merge 2 commits into
Conversation
ZabihollahNamazi
added
Needs Review
|
Could you look up
|
cjyuan
reviewed
Jul 23, 2026
There was a problem hiding this comment.
Is the change made in this file necessary to fix the bug?
In general, we should limit changes to those that are directly required to address the issue and avoid unrelated modifications.
Comment on lines
+42
to
+43
| .querySelector("[data-form='login']") | ||
| ?.addEventListener("submit", handleLogin); |
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
This PR replaces Old PR , which was closed due to a git branching issue. The previous branch accidentally included commits and tasks from an unrelated feature branch.
This new branch has been cleanly separated so it contains only the commits specific to this task.
I would really appreciate it if you could take a quick look and review this new PR . Thank you!