Skip to content

NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 1 | login bug #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZabihollahNamazi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 1 | login bug #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fbe734
git ignore
ZabihollahNamazi Jul 2, 2026
a74a03e
login
ZabihollahNamazi Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .gitignore
View file
Open in desktop

@cjyuan cjyuan Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change made in this file necessary to fix the bug?

In general, we should limit changes to those that are directly required to address the issue and avoid unrelated modifications.

Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
.DS_Store
# Virtual environments
venv/
.venv/
env/
.env/
ENV/

# Python cache files
__pycache__/
*.pyc
4 changes: 2 additions & 2 deletions front-end/views/profile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ function profileView(username) {
createLogin
);
document
.querySelector("[data-action='login']")
?.addEventListener("click", handleLogin);
.querySelector("[data-form='login']")
?.addEventListener("submit", handleLogin);
Comment on lines +42 to +43

@cjyuan cjyuan Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix the bug. Well done.


const profileData = state.profiles.find((p) => p.username === username);
if (profileData) {
Expand Down