Start runtime layer: leak-harness ingest bridge + C# harness skeleton (Plan.md §4)

[PhysShell]

Starts the runtime layer (Plan.md §4). The runtime layer confirms static
findings by observing the running app; its findings flow through the same
normalize → score → report pipeline as the static tiers, so a runtime-confirmed
leak in the same file as a static finding clusters with it into one
high-confidence result — the static→runtime confirmation in Plan.md §3.5.

Testable core — pure Python, Linux-CI-gated

• audit/runtime/ingest.py converts the leak-harness JSON result into SARIF.
  Only findings whose deterministic growth assertion tripped (leaked: true)
  become results; type-based findings (e.g. duplicate-immutable) stay file-level,
  reusing the Add merged-SARIF and HTML renderers — complete Phase 1 audit outputs #101 region fix. Its --selftest proves the runtime rules categorize
  correctly and that a static OWN014 plus a runtime leak in the same file form
  one high-confidence {own-check, leak-harness} cluster.
• categories.yml gains RUNTIME-* rule mappings for categories 2/3/4/11 — and
  4 (DependencyPropertyDescriptor.AddValueChanged) and 11 (duplicated-immutable
  data, the project's "gold") were NO-TOOL for static analysis, so the runtime
  layer is now their only tool — plus their severity baselines.
• CI's audit-selftests job runs the ingest selftest.

Windows / build-required skeleton — NOT CI-gated

Per the build-required tier (runs on the local Windows machine, never in CI):

• audit/runtime/LeakHarness/ — net472 C# harness (FlaUI + procdump + ClrMD):
  the deterministic GC+snapshot loop, growth assertion, and JSON result
  (Program.cs / Scenario.cs / HeapCounter.cs / LeakHarness.csproj).
• audit/runtime/scenarios/open-close-declaration.yml — one declarative
  leak-harness scenario with its schema documented inline.
• audit/runtime/README.md — the stack, the deterministic loop, and how it
  plugs into the unified report.

Tests

normalize 19/19 · score 11/11 · report 34/34 · run_static 14/14 · ingest 10/10 · ruff clean

End-to-end (through the real orchestrator): a static OWN014 (line 122) + a runtime
leak-harness finding (line 123) in the same file collapse into 1 high-confidence
finding — runtime confirms static.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QDPpNT9Uh8RoTrKPvgcoRE

---

Generated by Claude Code

Summary by CodeRabbit

• New Features
  • Added a runtime leak-harness workflow that replays UI scenarios, measures managed-heap growth, and flags findings when thresholds are exceeded.
  • Added CI support to ingest leak-harness results into runtime SARIF and combine them with existing audit outputs.
  • Extended the taxonomy with new runtime leak/duplication rule IDs and updated severities.
• Documentation
  • Added runtime-layer documentation, including harness setup, scenario workflow, and phase status.
• Bug Fixes
  • Ensured only confirmed leaks are reported and that runtime findings integrate reliably into normalization, scoring, and clustering.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 96b28934-9889-4700-a940-b837a0d6932b

📥 Commits

Reviewing files that changed from the base of the PR and between c03c926 and 405138c.

📒 Files selected for processing (4)

• audit/runtime/LeakHarness/HeapCounter.cs
• audit/runtime/LeakHarness/LeakHarness.csproj
• audit/runtime/LeakHarness/Program.cs
• audit/runtime/LeakHarness/Scenario.cs

🚧 Files skipped from review as they are similar to previous changes (4)

• audit/runtime/LeakHarness/LeakHarness.csproj
• audit/runtime/LeakHarness/Scenario.cs
• audit/runtime/LeakHarness/HeapCounter.cs
• audit/runtime/LeakHarness/Program.cs

---

📝 Walkthrough

Walkthrough

The PR adds a runtime leak-harness pipeline for Own.NET, including YAML scenario loading, heap-dump counting, SARIF conversion, taxonomy mappings, CI selftests, and README updates describing the runtime layer and its status.

Changes

Runtime audit pipeline

Layer / File(s)	Summary
Contracts, mappings, and scenario inputs audit/static/taxonomy/categories.yml, audit/runtime/LeakHarness/Scenario.cs, audit/runtime/scenarios/open-close-declaration.yml, audit/runtime/README.md	Runtime rule mappings, scenario POCOs, the open-close-declaration YAML scenario, and runtime README sections define the runtime layer inputs and reported status.
Heap snapshot counting audit/runtime/LeakHarness/HeapCounter.cs	HeapCounter runs procdump, loads the dump with ClrMD, counts matching managed types, and deletes the dump afterward.
LeakHarness execution audit/runtime/LeakHarness/LeakHarness.csproj, audit/runtime/LeakHarness/Program.cs	The new net472 harness project wires the executable; Program.cs loads the scenario, replays UI steps, triggers GC, snapshots counts, computes leak findings, and parses CLI options.
SARIF bridge and CI validation audit/runtime/ingest.py, .github/workflows/ci.yml, audit/static/run_static.py, audit/runtime/README.md	ingest.py converts leak-harness JSON into SARIF, exposes the CLI and selftest path, CI runs --selftest, and static aggregation now includes leak-harness.sarif.

Sequence Diagram(s)

sequenceDiagram
  participant CI
  participant ingest.py
  participant normalize_results
  participant parse_sarif
  participant score
  participant run_static.py

  CI->>ingest.py: --selftest
  ingest.py->>normalize_results: normalize runtime + static SARIF
  ingest.py->>parse_sarif: parse combined results
  ingest.py->>score: score clusters
  CI->>run_static.py: include leak-harness.sarif

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• PhysShell/Own.NET#100: Adds the runtime selftest path exercised by the new CI step and the ingest bridge’s normalize/score validation.
• PhysShell/Own.NET#101: Touches the same static SARIF aggregation path that now incorporates leak-harness.sarif.

Poem

I thumped through heaps and found the trail,
With YAML maps and SARIF mail.
The runtime burrow softly sings,
As CI checks its tiny springs.
🐇 Hop-hop — the leaks are in the lights!

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: starting the runtime layer with the ingest bridge and C# leak-harness skeleton.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/brave-gauss-elvquy

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4af07f6969

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (1)

audit/runtime/LeakHarness/LeakHarness.csproj (1)

16-16: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

<Platforms> may not force the build architecture you intend.

<Platforms> only declares the available platforms; it does not set PlatformTarget. Without <PlatformTarget>x64</PlatformTarget> (or building with -p:Platform=x64), the default net472 Exe build resolves to AnyCPU, which can run as 32-bit under Prefer32Bit. Since ClrMD reads a procdump full dump and FlaUI/heap inspection of the legacy target depend on predictable bitness, pin the target explicitly.

♻️ Proposed change

     <Platforms>x64</Platforms>
+    <PlatformTarget>x64</PlatformTarget>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@audit/runtime/LeakHarness/LeakHarness.csproj` at line 16, The LeakHarness
project currently only declares available platforms via Platforms, which does
not guarantee the build will run as x64. Update the LeakHarness.csproj
configuration to explicitly pin the target architecture with PlatformTarget in
the project settings so the net472 Exe is built and run as x64 instead of
defaulting to AnyCPU; use the existing project property block around Platforms
to locate the change.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@audit/runtime/LeakHarness/HeapCounter.cs`:
- Around line 65-77: The procdump invocation in HeapCounter’s dump-creation flow
can deadlock because both redirected streams are left unread before calling
p.WaitForExit(). Update this logic to drain StandardOutput and StandardError
while the process runs (or read them asynchronously), add a bounded wait/timeout
instead of an unbounded WaitForExit(), and then verify the process exit code
before relying on File.Exists(dumpPath). Use the existing _procdump,
ProcessStartInfo, and p variables to keep the fix localized.
- Around line 44-45: Guard against an empty ClrVersions collection in
HeapCounter when creating the runtime from the dump. In the HeapCounter logic
that loads the dump with DataTarget.LoadDump and accesses
dataTarget.ClrVersions[0], switch to a safe lookup such as FirstOrDefault, and
if no CLR version is present, throw a clear InvalidOperationException before
calling CreateRuntime().

In `@audit/runtime/LeakHarness/Program.cs`:
- Around line 75-79: The teardown in the finally block can throw and mask the
original failure when the target app is already exited or crashed. Update the
LeakHarness cleanup around app.Close() and app.Dispose() to be defensive by
handling teardown errors separately from the main try/finally flow, and use the
app symbol consistently so any cleanup exception is swallowed or logged without
replacing the original exception.

In `@audit/runtime/LeakHarness/Scenario.cs`:
- Around line 45-50: The Suspect model is silently defaulting Rule to
RUNTIME-LEAK-SUBSCRIPTION, which can misclassify malformed scenarios and emit
the wrong finding taxonomy; update the Suspect class in Scenario.cs so Rule is
required and has no fallback default, and make the scenario loading/validation
path fail fast when a Rule is missing, using the Suspect type and the Program.cs
finding emission flow as the key touchpoints.

---

Nitpick comments:
In `@audit/runtime/LeakHarness/LeakHarness.csproj`:
- Line 16: The LeakHarness project currently only declares available platforms
via Platforms, which does not guarantee the build will run as x64. Update the
LeakHarness.csproj configuration to explicitly pin the target architecture with
PlatformTarget in the project settings so the net472 Exe is built and run as x64
instead of defaulting to AnyCPU; use the existing project property block around
Platforms to locate the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d6917ae8-1e43-4506-8a78-f16a0d0c7203

📥 Commits

Reviewing files that changed from the base of the PR and between f67630c and 4af07f6.

📒 Files selected for processing (10)

• .github/workflows/ci.yml
• audit/README.md
• audit/runtime/LeakHarness/HeapCounter.cs
• audit/runtime/LeakHarness/LeakHarness.csproj
• audit/runtime/LeakHarness/Program.cs
• audit/runtime/LeakHarness/Scenario.cs
• audit/runtime/README.md
• audit/runtime/ingest.py
• audit/runtime/scenarios/open-close-declaration.yml
• audit/static/taxonomy/categories.yml