Add PropertyChanged-storm profiler (Plan.md §2 cat. 6)

[PhysShell]

What

The last runtime detector in the set: a PropertyChanged-storm profiler for Plan.md §2 category 6. Frequency — not correctness — is a runtime property. The static INPC0xx tier (cat. 5) catches a missing nameof or a broken arg; it cannot see that a property fires PropertyChanged thousands of times for one user operation, half of them with no value change, thrashing every binding. This profiler measures that storm.

How it fits the existing pipeline

Same shape as the leak-harness and duplicate-detector — a C# tool emits JSON, ingest.py bridges it to SARIF, and run_static folds it into the same normalize → score → report pipeline (so a storm in the same file as a static INPC0xx hit clusters with it → high confidence, §3.5).

Layer	Change
taxonomy (categories.yml)	RUNTIME-PROPCHANGED-STORM → category 6 (P2)
ingest.py	propertychanged_storm_to_sarif + --propertychanged-storm flag (in the mutually-exclusive source group). Keeps a resolved source line when present (→ clusters with INPC0xx); else a unique inpc://<type>/<property> synthetic URI so distinct storming properties stay distinct clusters. Generalized the duplicate-detector's _dup_uri into a shared _synthetic_uri(scheme, …) helper (heap:// vs inpc://).
run_static.py	folds propertychanged-storm.sarif into the runtime pickup loop
PropertyChangedStorm/ (C#)	reads an ETW .etl (Microsoft.Diagnostics.Tracing.TraceEvent) emitted by a diagnostic build's INPC EventSource, aggregates per (type, property), thresholds raises-per-operation, emits JSON. Windows/build-required, not CI-gated.

Verification

• ingest.py --selftest → 24/24 (below-threshold dropped, level warning, located storm keeps its line + forms 1 high-confidence cluster with a static INPC003, distinct properties stay distinct, category 6)
• run_static.py --selftest → 17/17 (asserts the storm SARIF is picked up)
• normalize 19/19, score 11/11, report 34/34 — unchanged
• ruff check audit/ clean; C# brace/paren-balanced with all TraceEvent tokens present
• End-to-end: storm JSON → SARIF → report renders two distinct [P2 · propertychanged-storm] clusters

As with the other harnesses, the C# is Windows/build-required and verified by reading (not compiled in Linux CI) — the Python bridge is what CI exercises.

🤖 Generated with Claude Code

---

Generated by Claude Code

Summary by CodeRabbit

• New Features
  • Added a new propertychanged-storm runtime diagnostic and integrated its SARIF output into the unified analysis pipeline.
  • Static runs now pick up propertychanged-storm results, and taxonomy includes category 6 with updated severity (P2).
• Bug Fixes
  • Improved clustering accuracy by preserving line locations when available and using distinct synthetic identifiers for unresolved storms.
  • Ensures report:false findings are omitted and related storm hits form correct high-confidence clusters.
• Documentation
  • Expanded runtime coverage and added profiler usage/output examples for propertychanged-storm.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ae38114c-5dc1-45bb-9ca6-d8d4c5a3a4ef

📥 Commits

Reviewing files that changed from the base of the PR and between 28f29b8 and be9c482.

📒 Files selected for processing (2)

• audit/runtime/README.md
• audit/runtime/ingest.py

✅ Files skipped from review due to trivial changes (1)

• audit/runtime/README.md

---

📝 Walkthrough

Walkthrough

Adds a new PropertyChangedStorm runtime executable, maps its findings to category 6, converts storm profiler output into SARIF with synthetic URIs when needed, and updates the static runner to ingest the new runtime tier.

Changes

PropertyChanged storm runtime pipeline

Layer / File(s)	Summary
Runtime surface and taxonomy audit/runtime/PropertyChangedStorm/PropertyChangedStorm.csproj, audit/static/taxonomy/categories.yml, audit/runtime/README.md	Adds the new PropertyChangedStorm executable project, maps RUNTIME-PROPCHANGED-STORM to category 6, and updates the runtime overview, layout, and status docs.
Shared synthetic URI normalization audit/runtime/ingest.py	Replaces the duplicate-detector-specific synthetic URI helper with a shared generator and updates duplicate-detector SARIF conversion to use it.
PropertyChanged-storm ingestion audit/runtime/ingest.py, audit/runtime/README.md	Adds --propertychanged-storm, converts profiler findings into SARIF with resolved locations or synthetic inpc:// URIs, and documents the profiler input and CLI flow.
Static pickup and validation audit/static/run_static.py, audit/runtime/ingest.py	Loads propertychanged-storm.sarif, extends the runtime selftests, and verifies the new tier is reported.

Sequence Diagram(s)

sequenceDiagram
  participant PropertyChangedStormProfiler
  participant audit_runtime_ingest_py as audit/runtime/ingest.py
  participant audit_static_run_static_py as audit/static/run_static.py
  PropertyChangedStormProfiler->>audit_runtime_ingest_py: emits propertychanged-storm JSON
  audit_runtime_ingest_py->>audit_static_run_static_py: writes propertychanged-storm.sarif

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• PhysShell/Own.NET#100: Shares the same static runtime pickup path, including audit/static/run_static.py and audit/static/taxonomy/categories.yml.
• PhysShell/Own.NET#102: Shares the same runtime SARIF ingestion and tiering path, with both PRs extending audit/runtime/ingest.py and audit/static/run_static.py.
• PhysShell/Own.NET#103: Also updates runtime ingestion and synthetic URI handling in audit/runtime/ingest.py alongside runtime-tier pickup in audit/static/run_static.py.

Poem

🐰 I sniffed a storm of property hops,
and packed each burst in tidy ops.
Through SARIF burrows, clues now flow,
with rabbit ears that twitch and know.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding a PropertyChanged-storm profiler for category 6.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/brave-gauss-elvquy

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2dd38ae7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@audit/runtime/ingest.py`:
- Around line 356-385: The selftest in ingest should cover unresolved storm
findings more strongly: add a second unresolved property alongside the existing
synthetic storm result so the test exercises multiple unresolved `inpc://...`
URIs, then tighten the assertions in
`propertychanged_storm_to_sarif`/`storm["runs"][0]["results"]` to verify those
synthetic URIs are distinct (or that they form separate clusters) rather than
only checking the total count and the single resolved
`src/Vm/DeclarationViewModel.cs` location.

In `@audit/runtime/README.md`:
- Around line 104-107: Update the README section that describes unresolved storm
clustering to match the synthetic URI shape produced by ingest.py: the current
wording says `inpc://<type>/<property>`, but the actual format is
`inpc://<type>/<nnnn>-<slug>`. Adjust the documentation in the relevant README
paragraph so it precisely reflects the URI emitted by the storm handling logic
in ingest.py and stays consistent with any report/assertion expectations.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 51167418-6d61-4143-a780-6dbcca7ac0c3

📥 Commits

Reviewing files that changed from the base of the PR and between 2b9098a and b2dd38a.

📒 Files selected for processing (6)

• audit/runtime/PropertyChangedStorm/Program.cs
• audit/runtime/PropertyChangedStorm/PropertyChangedStorm.csproj
• audit/runtime/README.md
• audit/runtime/ingest.py
• audit/static/run_static.py
• audit/static/taxonomy/categories.yml