Skip to content

rls: adaptive throttler - #6749

Merged
creamsoup merged 7 commits into
grpc:masterfrom
creamsoup:rls_adaptive_throttler
Mar 13, 2020
Merged

rls: adaptive throttler#6749
creamsoup merged 7 commits into
grpc:masterfrom
creamsoup:rls_adaptive_throttler

Conversation

@creamsoup

@creamsoup creamsoup commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@creamsoup creamsoup mentioned this pull request Mar 3, 2020
Merged
dapengzhang0
dapengzhang0 reviewed Mar 7, 2020
View reviewed changes
Comment thread rls/src/main/java/io/grpc/rls/internal/Throttler.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/Throttler.java
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
Comment thread rls/src/test/java/io/grpc/rls/internal/AdaptiveThrottlerTest.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
dapengzhang0
dapengzhang0 reviewed Mar 12, 2020
View reviewed changes

@dapengzhang0 dapengzhang0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java Outdated
Comment thread rls/src/test/java/io/grpc/rls/internal/AdaptiveThrottlerTest.java Outdated
Comment thread rls/src/test/java/io/grpc/rls/internal/AdaptiveThrottlerTest.java Outdated
dapengzhang0
dapengzhang0 approved these changes Mar 13, 2020
View reviewed changes
Comment thread rls/src/test/java/io/grpc/rls/internal/AdaptiveThrottlerTest.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/AdaptiveThrottler.java
@creamsoup
creamsoup merged commit a680c98 into grpc:master Mar 13, 2020
@creamsoup
creamsoup deleted the rls_adaptive_throttler branch March 13, 2020 01:45
@lock lock Bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@creamsoup @dapengzhang0