rls: LruCache interface and implementation - #6799
Merged
Merged
Conversation
dapengzhang0
reviewed
Apr 2, 2020
| @Override | ||
| @CheckReturnValue | ||
| public final boolean hasCacheEntry(K key) { | ||
| // call get to handle expired |
Contributor
There was a problem hiding this comment.
I'm not clear what the comment means. Is it necessary?
Contributor
Author
There was a problem hiding this comment.
i can improve the comment
if you get why it call readInternal instead of LinkedHashMap#contains without much thinking i am more than happy to remove it.
dapengzhang0
reviewed
Apr 9, 2020
dapengzhang0
left a comment
dapengzhang0
left a comment
Contributor
There was a problem hiding this comment.
Mostly LGTM, some small nit.
dapengzhang0
reviewed
Apr 9, 2020
dapengzhang0
approved these changes
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on Adaptive throttler (#6749)