Skip to content

feat(toggle): component can be used outside of ion-item - #26357

Merged
liamdebeasi merged 11 commits into
feature-7.0from
FW-2597
Nov 29, 2022
Merged

feat(toggle): component can be used outside of ion-item#26357
liamdebeasi merged 11 commits into
feature-7.0from
FW-2597

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #23213 resolves #25570

See: #25660

What is the new behavior?

  • ion-toggle can now be used independent of ion-item.
  • --background and --background-checked have been renamed --track-background and --track-background-checked, respectively.

Note: Each commit links back to a PR that describes the different functionality added. I opted to do this instead of adding all the changes directly into this branch.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Nov 23, 2022
@liamdebeasi liamdebeasi changed the title Fw 2597 feat(toggle): component can be used outside of ion-item Nov 23, 2022
@liamdebeasi
liamdebeasi marked this pull request as ready for review November 23, 2022 19:32
@liamdebeasi
liamdebeasi requested a review from a team as a code owner November 23, 2022 19:32
@averyrousseau

Copy link
Copy Markdown
Contributor

Looks like a couple textarea screenshot updates snuck in here?

  • core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-ios-ltr-Mobile-Chrome-linux.png
  • core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-ios-rtl-Mobile-Chrome-linux.png

Otherwise this all looks great 🎉

@liamdebeasi

Copy link
Copy Markdown
Contributor Author

All fixed! Thanks for catching that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants