fix(textarea): label color and focus highlight - #26664
Merged
Merged
Conversation
This reverts commit ece3f43.
|
|
Contributor
Author
|
I'm skipping a flaky test here: a842a78. I can create a new PR/build that adds a ticket to resolving it. It took 3-4x runs for screenshots to generate and 3x runs after commenting out this test for it to pass (all from flaky tests). |
sean-perkins
marked this pull request as ready for review
January 24, 2023 14:46
Contributor
|
Oddly enough I just fixed that test here #26667 😂 |
liamdebeasi
approved these changes
Jan 24, 2023
| outline: none; | ||
|
|
||
| background: transparent; | ||
| color: inherit; |
Contributor
Author
There was a problem hiding this comment.
Good question - I think I was adding it during testing and didn't clean it up after. I'll test more after my early meetings and confirm.
It looks like the cursor color also needs to be updated here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The modern textarea rendering does not account for a focus highlight or changing the floating label color.
Issue URL: Internal
What is the new behavior?
Does this introduce a breaking change?
Other information