fix(select): setting options async updates rendered text - #26667
Merged
Conversation
|
|
sean-perkins
approved these changes
Jan 24, 2023
13 tasks
|
I still have problem using reactive form and data loaded from server |
Contributor
Author
|
@aliabbaszade1990 Please file a new issue with a reproduction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #19324
Updating IonSelectOptions does not re-render the IonSelect component (these are not props and ion-select is not using
<slot>). As a result, the selected text of an IonSelect does not update. I fixed this issue back in 2019 in 1c9c18b. However, this behavior regressed in 48a2763#diff-62cbe1fafe96a79e15c9c13dbafef8698860cfb31976445de7e1773079061eb6L153. I failed to include a proper test case, which is why this was not caught.What is the new behavior?
Does this introduce a breaking change?
Other information