Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/src/components/select/select.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h, forceUpdate } from '@stencil/core';

import { getIonMode } from '../../global/ionic-global';
import type {
Expand Down Expand Up @@ -166,6 +166,14 @@ export class Select implements ComponentInterface {

this.mutationO = watchForOptions<HTMLIonSelectOptionElement>(this.el, 'ion-select-option', async () => {
this.updateOverlayOptions();

/**
* We need to re-render the component
* because one of the new ion-select-option
* elements may match the value. In this case,
* the rendered selected text should be updated.
*/
forceUpdate(this);
});
}

Expand Down
10 changes: 6 additions & 4 deletions core/src/components/select/test/async/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,15 @@
<ion-select id="actionSheet" interface="action-sheet" placeholder="A Placeholder"></ion-select>
</ion-item>

<ion-select id="with-value" placeholder="With Value" value="bird"></ion-select>

<button id="set-contents" onclick="setContents()">Set Contents</button>

<script>
let selects = document.querySelectorAll('ion-select');
const options = ['bird', 'dog', 'shark', 'lizard'];

setTimeout(() => {
const setContents = () => {
selects.forEach((select) => {
options.forEach((option) => {
let o = document.createElement('ion-select-option');
Expand All @@ -44,10 +48,8 @@
});

select.value = options[0];

window.dispatchEvent(new CustomEvent('selectValueSet'));
});
}, 1000);
};
</script>
</body>
</html>
17 changes: 12 additions & 5 deletions core/src/components/select/test/async/select.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,23 @@ import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright';

test.describe('select: async', () => {
test('should correctly set the value after a delay', async ({ page, skip }) => {
test.beforeEach(async ({ page, skip }) => {
skip.rtl('This is checking internal logic. RTL tests are not needed');
skip.mode('md');

await page.goto(`/src/components/select/test/async`);
const selectValueSet = await page.spyOnEvent('selectValueSet');
});
test('should correctly set the value after a delay', async ({ page }) => {
const select = page.locator('#default');
await page.click('#set-contents');

const select = await page.locator('#default');
await expect(select).toHaveJSProperty('value', 'bird');
});

await selectValueSet.next();
test('should re-render when options update but value is already set', async ({ page }) => {
const select = page.locator('#with-value');
await page.click('#set-contents');

await expect(select).toHaveJSProperty('value', 'bird');
await expect(select.locator('.select-text')).toHaveText('bird');
});
});