feat(button): support dynamic type - #27887
Merged
Merged
Conversation
|
|
brandyscarney
commented
Jul 28, 2023
brandyscarney
commented
Jul 28, 2023
brandyscarney
commented
Jul 28, 2023
2 tasks
brandyscarney
marked this pull request as ready for review
July 31, 2023 19:28
brandyscarney
requested review from
a team,
liamdebeasi and
mapsandapps
and removed request for
a team and
mapsandapps
July 31, 2023 19:28
liamdebeasi
reviewed
Aug 1, 2023
brandyscarney
commented
Aug 1, 2023
brandyscarney
commented
Aug 1, 2023
brandyscarney
commented
Aug 1, 2023
brandyscarney
commented
Aug 1, 2023
liamdebeasi
approved these changes
Aug 3, 2023
liamdebeasi
left a comment
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Looks good, great work! One outstanding question.
sean-perkins
pushed a commit
that referenced
this pull request
Aug 18, 2023
Adds support for dynamic type by converting `font-size` to use `rem` units and setting a `max-size` which matches native iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The button does not support dynamic type.
What is the new behavior?
Adds support for dynamic type by converting
font-sizeto useremunits and setting amax-sizewhich matches native iOS.Does this introduce a breaking change?
Other information
Dynamic type can be enabled with the following CSS: