Shard aware support - #4
Closed
fruch wants to merge 49 commits into
Closed
Conversation
* Add iterate_step test * ngdg docs integration
Merge ossnext ngdg
NGDG feature team branch for master
* Make graph metadata handling more robust
PYTHON-1205: Fix Undefined column name native_transport_address" error when connecting to C* 4.0
- fixing a version check in test_graph_query.py - revert guardrails prefx in test_failure_types.py - for tombstone test, delete cell in c* version < 4.0, else delete entire row
Update docs for 3.22 release
Remove temporarily the core engine graph documentation
fruch
force-pushed
the
scylla-3.21.0-shard-aware
branch
2 times, most recently
from
March 11, 2020 16:27
c619e5b to
16a903d
Compare
Closed
dimaqq
reviewed
Jun 2, 2020
Comment on lines
+625
to
+635
| def shard_id(self, t): | ||
| token = t.value | ||
| token += MIN_LONG | ||
| token <<= self.sharding_ignore_msb | ||
| tokLo = token & 0xffffffff | ||
| tokHi = (token >> 32) & 0xffffffff | ||
| mul1 = tokLo * self.shards_count | ||
| mul2 = tokHi * self.shards_count | ||
| _sum = (mul1 >> 32) + mul2 | ||
| output = _sum >> 32 | ||
| return output |
There was a problem hiding this comment.
Python integers are arbitrary in range, I think that the equivalent of 128-bit C code can be used instead.
There was a problem hiding this comment.
Ugh, I just notice that this PR is closed and #6 is the follow-up, reposting there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.